Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

197 reduction operation being executed in parallel with read modify write operation in onesourcegeneratepdf #209

Merged
merged 2 commits into from
Sep 17, 2024
Merged

197 reduction operation being executed in parallel with read modify write operation in onesourcegeneratepdf #209

merged 2 commits into from
Sep 17, 2024

Conversation

hdante
Copy link

@hdante hdante commented Sep 17, 2024

Change Description

This is version 2 of the original pull request for dealing with issue #197, there are no changes in the final code, so it's a simplification of the patchset. It still should be reviewed though because one comment in the makefile might be misplaced.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hdante hdante mentioned this pull request Sep 17, 2024
Closed
21 tasks
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.65%. Comparing base (a020312) to head (8bc2ba5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files          50       50           
  Lines        6229     6229           
  Branches      937      937           
=======================================
  Hits         4152     4152           
  Misses       2077     2077

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

johannct
johannct reviewed Sep 17, 2024
View reviewed changes
CMakeLists.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the comments are mixed up. How do you want to proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can edit directly in the branch on github

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just amend the commit and send version 3 then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged a fix to the file, I think we can go with that no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you merged it to the other pull request, which was increased now to 12 commits. I've fixed the second commit and we still have only two in this pull request, that's the idea.

@hdante hdante force-pushed the 197-reduction-operation-being-executed-in-parallel-with-read-modify-write-operation-in-onesourcegeneratepdf branch from 0de0de0 to 8bc2ba5 Compare September 17, 2024 19:59
@hdante
Copy link
Author

hdante commented Sep 17, 2024

Sent version 3, replacing commit 0de0de0 with 8bc2ba5 (fix location of comments about the thread sanitizer).

johannct
johannct approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@johannct johannct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged a fix to the file, I think we can go with that no?

@johannct
Copy link
Member

ok so it i cleared, you can merged if all is OK.

@hdante
Copy link
Author

hdante commented Sep 17, 2024

All good now, I don't have merge permission, so you'll need to do it.

@johannct johannct merged commit 09f45c1 into lephare-photoz:main Sep 17, 2024
13 checks passed
@hdante
Copy link
Author

hdante commented Sep 17, 2024

It worked now, I'll also close issue number #196.

@hdante hdante mentioned this pull request Sep 17, 2024
Closed
3 tasks
@hdante hdante deleted the 197-reduction-operation-being-executed-in-parallel-with-read-modify-write-operation-in-onesourcegeneratepdf branch September 17, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannct johannct johannct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdante @johannct